Set up i18n package #6991
Set up i18n package #6991
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
|
will take a look at this as i can - also #6993 might conflict |
|
I can recreate |
Can we ask help for to our in-house Turborepo specialist on Slack? |
|
@anthonyshew curious if you'd have some time to look at this and help out? the lint step is failing on the branch |
|
This is going to end up being a misconfiguration somewhere on ESLint or Digging in... |
|
After I couldn't sort it out, I asked Josh for his help. In typical Josh fashion, he overdelivered. |
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
force-pushed
the
feat/i18n-pkg
branch
from
1c29054
to
c61c241
Compare
github-actions
bot
removed
the
github_actions:pull-request
|
I've rebased the PR, hopefully this is fixed now! |
|
cc @JoshuaKGoldberg, it seems like tests are failing due to being unable to import the module; I assume it's because Jest is not using TypeScript's module resolution here. (note that our website uses a mix of TypeScript and plain ESM, So ESM should also be able to resolve said modules) My assumption here is that the Jest config needs to be updated to understand the module resolution for the said module. (Just a 5 minute guess, after looking on the CI logs) |
|
There are many issues here regarding module resolution during tests and build. This definitely needs to be addressed. |
github-actions
bot
removed
the
github_actions:pull-request
|
To be honest, the ESlint v8 setup is really flaky, we are using some weird canary versions of plugins, and I'm really uncomfortably with how things are 🫠 This added a hella of instability here. |
ovflowd
force-pushed
the
feat/i18n-pkg
branch
from
db8ef2b
to
837bdb1
Compare
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
* build: change package scopes * build: create packages workspace * feat: create initial i18n package * feat: create import locale fn * chore: some peaks * refactor: remove duplicated type * chore: set up lint * chore: dep fix * fix: crowdin config * fix: fix modules, eslint * fix: fixed lint, test and build process * chore: code review changes * chore: fix turbo.json * chore: fix package versions * fix: fix build due to shiki * chore: (unrelated) shiki js engine --------- Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Description
Set up i18n package
Validation
ESLint is throwing
Unable to resolve path to module '@node-core/website-i18n'error and I couldn't figure out the fix. Some help is welcomeRelated Issues
Related to #5405
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.